Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

player/audio: invert audio_started boolean #14616

Merged
merged 1 commit into from
Aug 1, 2024
Merged

player/audio: invert audio_started boolean #14616

merged 1 commit into from
Aug 1, 2024

Conversation

llyyr
Copy link
Contributor

@llyyr llyyr commented Jul 31, 2024

See individual commit messages

@llyyr llyyr mentioned this pull request Jul 31, 2024
Closed
6 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 31, 2024 •
edited
Loading

Download the artifacts for this pull request:

Windows
macOS

@Dudemanguy
Copy link
Member

If you simply invert the audio_started condition to delayed_audio_start, this seems to work for me. Waiting for audio_started takes too long which is what causes the first frame in #14615 to be off. Doesn't matter for most videos but it's noticeable there since each frame lasts for an extended period of time.

@llyyr
Copy link
Contributor Author

llyyr commented Jul 31, 2024

Changed it to just invert the condition. The sample I linked in IRC still freezes for a bit for me when the audio starts playing but it's not as important and can be looked at later

@llyyr llyyr changed the title player: loosen checks for adjust_sync again player/audio: invert audio_started boolean Jul 31, 2024
@Dudemanguy
Copy link
Member

I'm not 100% if it's needed, but it's probably worth clearing this bool in ao_chain_reset_state as well.

@llyyr
player/audio: invert audio_started boolean
e06e9c3 
Waiting for audio_started to be set to true takes too long which causes
us to miss it for the first frame, instead invert the condition so it's
set on the first frame.

Fixes mpv-player#14615
@Dudemanguy Dudemanguy merged commit 11ed012 into mpv-player:master Aug 1, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dudemanguy Dudemanguy Dudemanguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@llyyr @Dudemanguy